nwangtw commented on code in PR #3857:
URL: https://github.com/apache/incubator-heron/pull/3857#discussion_r1011383403
##########
heron/tools/cli/src/python/execute.py:
##########
@@ -101,8 +101,15 @@ def heron_tar(class_name, topology_tar, arguments,
tmpdir_root, java_defines):
'''
# Extract tar to a tmp folder.
tmpdir = tempfile.mkdtemp(dir=tmpdir_root, prefix='tmp')
+ tmpdir_abs = os.path.abspath(tmpdir)
with contextlib.closing(tarfile.open(topology_tar)) as tar:
+ # Validate file paths
+ for name in tar.getnames():
+ untarpath_abs = os.path.abspath(os.path.join(tmpdir, name))
+ if not untarpath_abs.startswith(tmpdir_abs):
Review Comment:
@nicknezis It might be necessary. I wasn't sure about the exact cases that
trigger the issue and it is not easy to reason the code. Maybe add a comment
with the vulnerability link so that in the future it is easy for other people
to understand the code.
##########
heron/tools/cli/src/python/execute.py:
##########
@@ -101,8 +101,15 @@ def heron_tar(class_name, topology_tar, arguments,
tmpdir_root, java_defines):
'''
# Extract tar to a tmp folder.
tmpdir = tempfile.mkdtemp(dir=tmpdir_root, prefix='tmp')
+ tmpdir_abs = os.path.abspath(tmpdir)
with contextlib.closing(tarfile.open(topology_tar)) as tar:
+ # Validate file paths
+ for name in tar.getnames():
+ untarpath_abs = os.path.abspath(os.path.join(tmpdir, name))
+ if not untarpath_abs.startswith(tmpdir_abs):
+ raise Exception(f"tar attempted to extract a file outside the
destination directory: {name}")
Review Comment:
maybe useful to log `untarpath_abs` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
