nwangtw commented on issue #2908: reorder operations in zk_client destructor URL: https://github.com/apache/incubator-heron/pull/2908#issuecomment-392214519 Discussed offline. Update: The fix is valid and helpful in the current implementation. The questions are about the implementation of queue and if we can handle zk events in a simpler way. So we agreed to submit the fix which could improve heron reliability, and then discuss about the zk client implementation in future. In conclusion, we have a green light to merge~
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
