nwangtw commented on a change in pull request #2910: make LocalFSStorage clean
checkpoints before store
URL: https://github.com/apache/incubator-heron/pull/2910#discussion_r191929947
##########
File path:
heron/statefulstorages/src/java/org/apache/heron/statefulstorage/localfs/LocalFileSystemStorage.java
##########
@@ -32,20 +34,25 @@
import org.apache.heron.spi.statefulstorage.IStatefulStorage;
import org.apache.heron.spi.statefulstorage.StatefulStorageException;
-public class LocalFileSystemStorage implements IStatefulStorage {
+public class LocalFileSystemStorage implements IStatefulStorage {
private static final Logger LOG =
Logger.getLogger(LocalFileSystemStorage.class.getName());
private static final String ROOT_PATH_KEY =
"heron.statefulstorage.localfs.root.path";
+ private static final String MAX_CHECKPOINTS_KEY =
"heron.statefulstorage.localfs.max.checkpoints";
private String checkpointRootPath;
+ private int maxCheckpoints;
@Override
public void init(Map<String, Object> conf) throws StatefulStorageException {
checkpointRootPath = (String) conf.get(ROOT_PATH_KEY);
+ maxCheckpoints = (int) conf.get(MAX_CHECKPOINTS_KEY);
Review comment:
could be helpful to have a default value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
