nwangtw commented on a change in pull request #2923: [healthmgr] Enable runtime
toggle for AutoRestartBackpressureContainerPolicy
URL: https://github.com/apache/incubator-heron/pull/2923#discussion_r196239712
##########
File path:
heron/healthmgr/src/java/org/apache/heron/healthmgr/common/PhysicalPlanProvider.java
##########
@@ -78,11 +78,9 @@ public synchronized void onEvent(ContainerRestart event) {
@Override
public synchronized PhysicalPlan get() {
+ physicalPlan = stateManagerAdaptor.getPhysicalPlan(topologyName);
Review comment:
hmm. this seems to change some assumption that physicalplan doesn't change
by itself. is this really necessary to get physical plan every time? and how
often the function get called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
