nlu90 commented on a change in pull request #2934: [aurora] add metadata support for aurora URL: https://github.com/apache/incubator-heron/pull/2934#discussion_r197466443
########## File path: heron/schedulers/src/java/org/apache/heron/scheduler/aurora/AuroraField.java ########## @@ -35,5 +35,8 @@ TIER, TOPOLOGY_ARGUMENTS, TOPOLOGY_NAME, - TOPOLOGY_PACKAGE_URI + TOPOLOGY_PACKAGE_URI, + AURORA_METADATA_1, Review comment: 1. Why three such aurora configs, not less or more? 2. Is it possible to assign them meaningful names instead of 1,2,3? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
