Code0x58 commented on a change in pull request #2934: [aurora] add metadata
support for aurora
URL: https://github.com/apache/incubator-heron/pull/2934#discussion_r197505046
##########
File path:
heron/schedulers/src/java/org/apache/heron/scheduler/aurora/AuroraField.java
##########
@@ -35,5 +35,8 @@
TIER,
TOPOLOGY_ARGUMENTS,
TOPOLOGY_NAME,
- TOPOLOGY_PACKAGE_URI
+ TOPOLOGY_PACKAGE_URI,
+ AURORA_METADATA_1,
Review comment:
_just speculating:_ the `SCHEDULER_PROPERTIES
("heron.scheduler.properties", Type.PROPERTIES),` line in `Key.java` looks
interesting:
* does `Type.PROPERTIES` allow you do take a set/map of things instead of a
string?
* can `SCHEDULER_PROPERTIES` be used instead of adding these new options?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
