Code0x58 commented on a change in pull request #2924: Py3 heronpy
URL: https://github.com/apache/incubator-heron/pull/2924#discussion_r197701632
##########
File path: scripts/packages/BUILD
##########
@@ -474,9 +474,11 @@ genrule(
'rm setup.py.template',
'tree $$HERONPY_DIR',
'/usr/bin/env python2.7 setup.py sdist',
- '/usr/bin/env python2.7 setup.py bdist_wheel',
+ '/usr/bin/env python2.7 setup.py bdist_wheel --universal',
+ 'cd -',
'ls -l $$HERONPY_DIR/dist',
- 'cp $$HERONPY_DIR/dist/heronpy-*-py2-*.whl $$OUTPUT_DIR',
+ 'cp $$HERONPY_DIR/dist/heronpy-*-py2.py3-*.whl $$OUTPUT_DIR',
+ 'cp $$HERONPY_DIR/dist/heronpy-*-py2.py3-*.whl "$@"',
Review comment:
The universal package works locally, so the next step is to make sure it can
run on the executor image. I'll get stuck into changing the Dockerfiles to
include python3.6 over the next few days. My thinking is that they should
include the latest stable python, so PEXs only need to have python3 in their
shebang and they'll just work.
_p.s. the WIP commit is ugly, I pushed it to switch machines for a few days_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
