nwangtw commented on a change in pull request #2934: [aurora] add metadata
support for aurora
URL: https://github.com/apache/incubator-heron/pull/2934#discussion_r200792548
##########
File path:
heron/schedulers/src/java/org/apache/heron/scheduler/aurora/AuroraScheduler.java
##########
@@ -279,6 +279,19 @@ public void
removeContainers(Set<PackingPlan.ContainerPlan> containersToRemove)
auroraProperties.put(AuroraField.CORE_PACKAGE_URI, heronCoreReleasePkgURI);
auroraProperties.put(AuroraField.TOPOLOGY_PACKAGE_URI, topologyPkgURI);
+ if (config.containsKey(Key.SCHEDULER_PROPERTIES)) {
Review comment:
Still not idea to have AURORA_METADATA_1, AURORA_METADATA_2, and
AURORA_METADATA_3.
I am thinking maybe in addition to auroraProperties, which is for standard
properties with type Map[AuroraField, String], we can add another Map[String,
String] extraProperties for these dynamic properties, so that we can avoid the
hard coded names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
