Code0x58 commented on a change in pull request #2975: Docker Ubuntu tweaks
URL: https://github.com/apache/incubator-heron/pull/2975#discussion_r209436006
 
 

 ##########
 File path: docker/dist/Dockerfile.dist.ubuntu14.04
 ##########
 @@ -9,7 +9,7 @@ RUN apt-get -y update && apt-get -y install \
     apt-get clean all
 
 RUN add-apt-repository ppa:openjdk-r/ppa && apt-get -y update && \
-    apt-get -y install openjdk-8-jdk && apt-get clean all
+    apt-get -y install openjdk-8-jdk-headless && apt-get clean all
 
 Review comment:
   The `apt-get clean` is redundant as it is a post build 
[[src](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#apt-get)]:
   > Official Debian and Ubuntu images [automatically run `apt-get 
clean`](https://github.com/moby/moby/blob/03e2923e42446dbb830c654d0eec323a0b4ef02a/contrib/mkimage/debootstrap#L82-L105),
 so explicit invocation is not required.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to