nlu90 commented on a change in pull request #2979: [healthmgr] refactor 
physicalplanprovider and topologyprovider
URL: https://github.com/apache/incubator-heron/pull/2979#discussion_r209443070
 
 

 ##########
 File path: 
heron/healthmgr/src/java/org/apache/heron/healthmgr/policy/ToggleablePolicy.java
 ##########
 @@ -75,24 +75,33 @@ public ToggleablePolicy(
 
   @Override
   public Collection<Measurement> executeSensors() {
-    for (TopologyAPI.Config.KeyValue kv
-        : 
physicalPlanProvider.get().getTopology().getTopologyConfig().getKvsList()) {
-      LOG.fine("kv " + kv.getKey() + ":" + kv.getValue());
-      if (kv.getKey().equals(policyIdRuntime)) {
-        try {
-          PolicyMode val = PolicyMode.valueOf(kv.getValue());
-          if (!policyMode.equals(val)) {
-            policyMode = val;
-            LOG.info("policy " + policyId + " status changed to " + 
policyMode);
-          } else {
-            LOG.fine("policy " + policyId + " status remains same " + 
policyMode);
+    LOG.info("----------------------------------");
 
 Review comment:
   is this log really needed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to