nlu90 commented on a change in pull request #2978: first checkin for heron ml URL: https://github.com/apache/incubator-heron/pull/2978#discussion_r209443422
########## File path: heron/mlmgr/src/main/java/org/apache/heron/LocalStormDoTask.java ########## @@ -0,0 +1,82 @@ +package org.apache.heron; Review comment: the package path should be `org.apache.heron.ml` if it's a general class needed by all machine learning runtime. If it's specific for samoa, then the package path should be `org.apache.heron.ml.samoa`. And this also applies to all the following files. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
