nwangtw commented on a change in pull request #3095: [Java Streamlet API]
Extend validations
URL: https://github.com/apache/incubator-heron/pull/3095#discussion_r228986931
##########
File path: heron/api/src/java/org/apache/heron/streamlet/impl/BuilderImpl.java
##########
@@ -44,6 +46,7 @@ public BuilderImpl() {
@Override
public <R> Streamlet<R> newSource(SerializableSupplier<R> supplier) {
+ Preconditions.checkNotNull(supplier, "supplier must not be null.");
Review comment:
why use Preconditions? require() is not enough?
We are hoping to get rid of guava library since it is too big. :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
