erenavsarogullari commented on a change in pull request #3109: Add withStream()
in Streamlet to support stream selection
URL: https://github.com/apache/incubator-heron/pull/3109#discussion_r233257145
##########
File path:
heron/api/tests/java/org/apache/heron/streamlet/impl/StreamletImplTest.java
##########
@@ -81,6 +82,22 @@ public void testBasicParams() throws Exception {
assertEquals(bStreamlet.getChildren().size(), 0);
}
+ @Test
+ public void testWithStream() {
Review comment:
Test coverage can be useful for the following cases:
- if `streamId` is set duplicate (`test_stream2 == test_stream3`)
- if `streamId` is set `Bolt` level again as different from `Spout`'s
`streamId`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
