erenavsarogullari opened a new pull request #3115: [Java Streamlet API] Move Source Logics to Builder URL: https://github.com/apache/incubator-heron/pull/3115 ### Motivation Currently, `StreamletImpl` covers the following logic tiers ``` 1- Sources 2- Transformations + Sinks 3- Core logic: - Build, - setDefaultStreamletNameIfNotExist, - StreamletNamePrefix etc. ``` `StreamletImpl`' s scope grows up day by day in the light of new `Streamlet Transformations` (what we are working on). So, This PR proposes to be splitted `StreamletImpl` logic to following 3 parts: ``` 1- Following Source Streamlet functions (Step 1) can move to BuilderImpl - createSupplierStreamlet, - createGeneratorStreamlet, - createSpoutStreamlet 2- Core logic (Step 3) can move to abstract BaseStreamletImpl class (which will be new generated) and it can be extended by StreamletImpl. This step will be addressed via next PR. 3- StreamletImpl will cover just Transformations + Sinks logics (Step 3) as same as current. ``` ### Modifications Following Source Streamlet functions are moved to `BuilderImpl` so they can easily be initiated by `BuilderImpl` without having any dependency to `StreamletImpl`. ``` - createSupplierStreamlet, - createGeneratorStreamlet, - createSpoutStreamlet ``` ### Test Coverage Existing UTs have been updated to cover this patch.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
