nlu90 commented on a change in pull request #3141: Clean up
heron-client-install.sh
URL: https://github.com/apache/incubator-heron/pull/3141#discussion_r245096098
##########
File path: docker/scripts/ci-docker.sh
##########
@@ -66,18 +66,14 @@ build_exec_image() {
setup_scratch_dir $SCRATCH_DIR
# need to copy artifacts locally
- TOOLS_FILE="$OUTPUT_DIRECTORY/heron-tools-install.sh"
- TOOLS_OUT_FILE="$SCRATCH_DIR/artifacts/heron-tools-install.sh"
+ TOOLS_FILE="$OUTPUT_DIRECTORY/heron-install.sh"
Review comment:
variable name`INSTALL_FILE` makes more sense. And also same the followings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
