huijunwu commented on a change in pull request #3162: keep executor running
when `heron update` adds containers
URL: https://github.com/apache/incubator-heron/pull/3162#discussion_r249181022
##########
File path: heron/executor/src/python/heron_executor.py
##########
@@ -976,6 +979,14 @@ def get_commands_to_run(self):
# During shutdown the watch might get triggered with the empty packing plan
if len(self.packing_plan.container_plans) == 0:
return {}
+ if self._get_instance_plans(self.packing_plan, self.shard) is None and
self.shard != 0:
+ retval = {}
+ retval['heron-shell'] = [
+ '%s' % self.heron_shell_binary,
Review comment:
health-check in shell returns `ok` then aurora returns. thus shell is
mandatory to run in container
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
