nwangtw commented on a change in pull request #3163: Add target to generate packages for heron simulator URL: https://github.com/apache/incubator-heron/pull/3163#discussion_r249602918
########## File path: heron/simulator/src/java/shade.conf ########## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: Heron API is included in this build which has this shade. I think it is safer to apply the same process. I think the shade is used to avoid conflicts if different version of the libraries are used in the user topology. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
