nwangtw commented on a change in pull request #3178: Soften padding constraint
URL: https://github.com/apache/incubator-heron/pull/3178#discussion_r251643083
##########
File path:
heron/packing/src/java/org/apache/heron/packing/roundrobin/RoundRobinPacking.java
##########
@@ -347,6 +381,24 @@ private ByteAmount
getContainerRamPadding(List<TopologyAPI.Config.KeyValue> topo
return allocation;
}
+
+ /**
+ * Sort the components in decreasing order based on their RAM requirements
+ *
+ * @return The sorted list of components and their RAM requirements
+ */
+ private ArrayList<RamRequirement> getSortedRAMInstances(Set<String>
componentNames) {
Review comment:
- should be "components"
- maybe better to document why Ram only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
