xiaoyao1991 commented on a change in pull request #3180: [Streamlet] Fix 
streamlet config to apply cpu and ram in topology
URL: https://github.com/apache/incubator-heron/pull/3180#discussion_r251994133
 
 

 ##########
 File path: heron/api/src/java/org/apache/heron/streamlet/Config.java
 ##########
 @@ -63,7 +64,7 @@
     static final boolean USE_KRYO = true;
     static final org.apache.heron.api.Config CONFIG = new 
org.apache.heron.api.Config();
     static final double CPU = 1.0;
-    static final long RAM = 100 * MB;
+    static final ByteAmount RAM = ByteAmount.fromMegabytes(100);
 
 Review comment:
   Why is this 100MB by default? This would almost certainly fail during 
submission because it's lower than min RAM. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to