nwangtw commented on a change in pull request #3181: Add ci script for building docker image URL: https://github.com/apache/incubator-heron/pull/3181#discussion_r252450585
########## File path: scripts/ci/build_release_packages.sh ########## @@ -51,11 +51,11 @@ chmod +x heron/tools/apiserver/src/shell/heron-apiserver.sh bash scripts/release/status.sh # Create a temporary director for generated files -mkdir -p ~/heron-release -rm -f ~/heron-release/*.* -./docker/scripts/build-artifacts.sh $BUILD_OS $VERSION_TAG ~/heron-release +mkdir -p $TEMP_RELEASE_DIR +rm -f $TEMP_RELEASE_DIR/*.* +./docker/scripts/build-artifacts.sh $BUILD_OS $VERSION_TAG rm -f $TEMP_RELEASE_DIR Review comment: good catch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
