xiaoyao1991 opened a new pull request #3187: Consolidate Packing URL: https://github.com/apache/incubator-heron/pull/3187 Currently, different packing algorithms assume different things and follow different semantics for the user-set configs. Because of it, there exist some code duplicates and it's not friendly for new packing algorithms. This PR is an attempt to address this issue and consolidate the three existing packing algorithms. Major behavior changes are: - `FirstFitDecreasingPacking` and `ResourceCompliantRoundRobinPacking` now take container-level resource constraints from `topology.container.cpu`, `topology.container.ram`, and `topology.container.disk` instead of from hints. - `FirstFitDecreasingPacking` and `ResourceCompliantRoundRobinPacking` now determine padding resource by taking `max(containerResource * padding%, paddingAmount)` This PR also revamp tests and code reuse.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
