nwangtw commented on a change in pull request #3188: Revamp Packing tests
URL: https://github.com/apache/incubator-heron/pull/3188#discussion_r254053401
##########
File path:
heron/packing/src/java/org/apache/heron/packing/roundrobin/RoundRobinPacking.java
##########
@@ -463,11 +463,15 @@ private ByteAmount getContainerDiskHint(Map<Integer,
List<InstanceId>> allocatio
* @return Container RAM requirement
*/
private ByteAmount getContainerRamHint(Map<Integer, List<InstanceId>>
allocation) {
+ ByteAmount defaultContainerRam = instanceRamDefault
Review comment:
same as #3187, could it be helpful to refactor this logic into a function?
since the logic is used in a few places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
