xiaoyao1991 commented on a change in pull request #3188: Revamp Packing tests
URL: https://github.com/apache/incubator-heron/pull/3188#discussion_r254077568
##########
File path: heron/packing/tests/java/org/apache/heron/packing/AssertPacking.java
##########
@@ -42,7 +42,7 @@
*/
public final class AssertPacking {
- private static final double DELTA = 0.1;
+ public static final double DELTA = 0.1;
Review comment:
It's `public` in the test scope so it should be fine I think. I made it
public because other test files involve comparing double too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
