nwangtw commented on a change in pull request #3189: Add metrics for total time
spent on user logic
URL: https://github.com/apache/incubator-heron/pull/3189#discussion_r254093896
##########
File path:
heron/common/src/java/org/apache/heron/common/utils/metrics/BoltMetrics.java
##########
@@ -127,6 +130,7 @@ public void failedTuple(String streamId, String
sourceComponent, long latency) {
public void executeTuple(String streamId, String sourceComponent, long
latency) {
executeCount.incr();
executeLatency.update(latency);
+ executeTimeNs.incrBy(latency);
Review comment:
correct in most cases. One exception is that count.incr() and
latency().update() are not atomic, so in theory they might be separated into
two intervals. This
The more straightforward motivation is more like the FullBoltMetrics class
has the metric but the others dont. This PR makes them more consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
