nwangtw commented on a change in pull request #3187: Consolidate Packing
URL: https://github.com/apache/incubator-heron/pull/3187#discussion_r255196207
##########
File path:
heron/packing/tests/java/org/apache/heron/packing/CommonPackingTests.java
##########
@@ -45,12 +46,9 @@
* There is some common functionality in multiple packing plans. This class
contains common tests.
*/
public abstract class CommonPackingTests {
- protected static final String A = "A";
- protected static final String B = "B";
-
- protected static final String BOLT_NAME = "bolt";
- protected static final String SPOUT_NAME = "spout";
- protected static final int DEFAULT_CONTAINER_PADDING = 10;
+ protected static final String BOLT_NAME = "B";
Review comment:
A and B may not be good Spout and Bolt names
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
