nwangtw commented on a change in pull request #3195: 2D(RAM, CPU) Vector
Binpacking (FirstFit Decreasing) Packing
URL: https://github.com/apache/incubator-heron/pull/3195#discussion_r258298133
##########
File path: heron/spi/src/java/org/apache/heron/spi/packing/PackingPlan.java
##########
@@ -324,4 +390,39 @@ public String toString() {
return str + "}";
}
}
+
+ public static class ResourceUtility implements Comparable<ResourceUtility> {
Review comment:
Suggest to move out to its own file.
Also, why disk is not included?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
