nwangtw commented on a change in pull request #3195: Refactor
FirstFitDecreasingPacking to support CPU intensive topologies
URL: https://github.com/apache/incubator-heron/pull/3195#discussion_r259181465
##########
File path: heron/api/src/java/org/apache/heron/api/Config.java
##########
@@ -215,6 +215,11 @@
* spout0:12434,spout1:345353,bolt1:545356.
*/
public static final String TOPOLOGY_COMPONENT_DISKMAP =
"topology.component.diskmap";
+ /**
+ * Sorting strategy for FirstFitDecreasingPacking algorithm.
+ * RAM_FIRST (default), or CPU_FIRST
+ */
+ public static final String TOPOLOGY_FFD_SORTING_STRATEGY =
"topology.ffd.sorting.strategy";
Review comment:
I am wondering if there is a better place for this config. @huijunw @nlu90
any thoughts?
Also if it will be kept here. I would suggest make the name and string like
topology.packing.ffd....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
