worlvlhole commented on issue #3198: Feature/create kafka spout URL: https://github.com/apache/incubator-heron/pull/3198#issuecomment-468687819 @simingweng Im having trouble following what you are doing when there is a failed tuple. Not due to your code being confusing, i am just missing something and would like an explanation. Are you replaying all tuples from the most recent failed offset? From what I have read in the code, i have come to believe this is your process, is this correct? 1. Add offset to failure registry. 2. Check if there is a failure. 3. Seek to failure offset. 4. Remove previous acks 5. Continue emitting.. The code looks good. I plan on using this shortly and will hopefully have more feedback after i get into it. Thanks!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
