nwangtw commented on a change in pull request #3209: Updates for Bazel 0.23
compatibility
URL: https://github.com/apache/incubator-heron/pull/3209#discussion_r264864813
##########
File path: WORKSPACE
##########
@@ -846,146 +854,161 @@ http_archive(
sha256 =
"ae27cdbcd6a2f935baa78e4f21f675649271634c092b1be01469440495609d0e",
)
-new_http_archive(
+http_archive(
name = "org_libevent_libevent",
urls =
["https://github.com/libevent/libevent/releases/download/release-2.1.8-stable/libevent-2.1.8-stable.tar.gz";],
strip_prefix = "libevent-2.1.8-stable",
- build_file = "third_party/libevent/libevent.BUILD",
+ build_file = "@//:third_party/libevent/libevent.BUILD",
sha256 =
"965cc5a8bb46ce4199a47e9b2c9e1cae3b137e8356ffdad6d94d3b9069b71dc2",
)
-new_http_archive(
+http_archive(
name = "org_nongnu_libunwind",
urls =
["http://download.savannah.nongnu.org/releases/libunwind/libunwind-1.1.tar.gz";],
strip_prefix = "libunwind-1.1",
- build_file = "third_party/libunwind/libunwind.BUILD",
+ build_file = "@//:third_party/libunwind/libunwind.BUILD",
sha256 =
"9dfe0fcae2a866de9d3942c66995e4b460230446887dbdab302d41a8aee8d09a",
)
-new_http_archive(
+http_archive(
name = "org_apache_zookeeper",
urls =
["http://archive.apache.org/dist/zookeeper/zookeeper-3.4.10/zookeeper-3.4.10.tar.gz";],
strip_prefix = "zookeeper-3.4.10",
- build_file = "third_party/zookeeper/zookeeper.BUILD",
+ build_file = "@//:third_party/zookeeper/zookeeper.BUILD",
sha256 =
"7f7f5414e044ac11fee2a1e0bc225469f51fb0cdf821e67df762a43098223f27",
)
-new_http_archive(
+http_archive(
name = "com_github_gperftools_gperftools",
urls =
["https://github.com/gperftools/gperftools/releases/download/gperftools-2.4/gperftools-2.4.tar.gz";],
strip_prefix = "gperftools-2.4",
- build_file = "third_party/gperftools/gperftools.BUILD",
+ build_file = "@//:third_party/gperftools/gperftools.BUILD",
sha256 =
"982a37226eb42f40714e26b8076815d5ea677a422fb52ff8bfca3704d9c30a2d",
)
-new_http_archive(
+http_archive(
name = "com_github_google_glog",
urls = ["https://github.com/google/glog/archive/v0.3.5.tar.gz";],
strip_prefix = "glog-0.3.5",
- build_file = "third_party/glog/glog.BUILD",
+ build_file = "@//:third_party/glog/glog.BUILD",
sha256 =
"7580e408a2c0b5a89ca214739978ce6ff480b5e7d8d7698a2aa92fadc484d1e0",
)
-new_http_archive(
+http_archive(
name = "com_google_googletest",
urls =
["https://github.com/google/googletest/archive/release-1.8.0.tar.gz";],
strip_prefix = "googletest-release-1.8.0",
- build_file = "third_party/gtest/gtest.BUILD",
+ build_file = "@//:third_party/gtest/gtest.BUILD",
sha256 =
"58a6f4277ca2bc8565222b3bbd58a177609e9c488e8a72649359ba51450db7d8",
)
-new_http_archive(
+http_archive(
name = "com_github_cereal",
urls = ["https://github.com/USCiLab/cereal/archive/v1.2.2.tar.gz";],
strip_prefix = "cereal-1.2.2",
- build_file = "third_party/cereal/cereal.BUILD",
+ build_file = "@//:third_party/cereal/cereal.BUILD",
sha256 =
"1921f26d2e1daf9132da3c432e2fd02093ecaedf846e65d7679ddf868c7289c4",
)
-new_http_archive(
+http_archive(
name = "com_github_jbeder_yaml_cpp",
urls =
["https://github.com/jbeder/yaml-cpp/archive/yaml-cpp-0.6.2.tar.gz";],
strip_prefix = "yaml-cpp-yaml-cpp-0.6.2",
- build_file = "third_party/yaml-cpp/yaml.BUILD",
+ build_file = "@//:third_party/yaml-cpp/yaml.BUILD",
+ sha256 =
"e4d8560e163c3d875fd5d9e5542b5fd5bec810febdcba61481fe5fc4e6b1fd05",
)
-new_http_archive(
+http_archive(
name = "com_github_danmar_cppcheck",
urls = ["https://github.com/danmar/cppcheck/archive/1.87.zip";],
strip_prefix = "cppcheck-1.87",
- build_file = "third_party/cppcheck/cppcheck.BUILD",
+ build_file = "@//:third_party/cppcheck/cppcheck.BUILD",
+ sha256 =
"b3de7fbdc1a23d7341b55f7f88877e106a76847bd5a07fa721c07310b625318b",
)
# end 3rdparty C++ dependencies
# for helm
-new_http_archive(
+http_archive(
name = "helm_mac",
- url =
"https://storage.googleapis.com/kubernetes-helm/helm-v2.7.2-darwin-amd64.tar.gz";,
+ urls =
["https://storage.googleapis.com/kubernetes-helm/helm-v2.7.2-darwin-amd64.tar.gz";],
strip_prefix = "darwin-amd64",
- build_file = "third_party/helm/helm.BUILD",
+ build_file = "@//:third_party/helm/helm.BUILD",
sha256 =
"5058142bcd6e16b7e01695a8f258d27ae0b6469caf227ddf6aa2181405e6aa8e",
)
-new_http_archive(
+http_archive(
name = "helm_linux",
- url =
"https://storage.googleapis.com/kubernetes-helm/helm-v2.7.2-linux-amd64.tar.gz";,
+ urls =
["https://storage.googleapis.com/kubernetes-helm/helm-v2.7.2-linux-amd64.tar.gz";],
strip_prefix = "linux-amd64",
- build_file = "third_party/helm/helm.BUILD",
+ build_file = "@//:third_party/helm/helm.BUILD",
sha256 =
"9f04c4824fc751d6c932ae5b93f7336eae06e78315352aa80241066aa1d66c49",
)
# end helm
# for docker image building
http_archive(
name = "io_bazel_rules_docker",
- urls =
["https://github.com/bazelbuild/rules_docker/archive/v0.4.0.tar.gz";],
- strip_prefix = "rules_docker-0.4.0",
- sha256 =
"6dede2c65ce86289969b907f343a1382d33c14fbce5e30dd17bb59bb55bb6593",
+ urls =
["https://github.com/bazelbuild/rules_docker/archive/v0.7.0.tar.gz";],
+ strip_prefix = "rules_docker-0.7.0",
+ sha256 =
"aed1c249d4ec8f703edddf35cbe9dfaca0b5f5ea6e4cd9e83e99f3b0d1136c3d",
)
load(
- "@io_bazel_rules_docker//container:container.bzl",
- "container_pull",
+ "@io_bazel_rules_docker//repositories:repositories.bzl",
container_repositories = "repositories",
)
-# This is NOT needed when going through the language lang_image
-# "repositories" function(s).
container_repositories()
+load(
Review comment:
Got it. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
