joshfischer1108 commented on a change in pull request #3235: fix the issue that
Heron ECO stream builder does not handle IStatefulWindowedBolt
URL: https://github.com/apache/incubator-heron/pull/3235#discussion_r273270776
##########
File path: tools/java/src/org/apache/bazel/cppcheck/CppCheck.java
##########
@@ -113,7 +114,7 @@ private static void runChecker(List<String> command)
throws IOException {
if (cppcheck.exitValue() == 1) {
LOG.warning("cppcheck detected bad cpp files.");
- System.exit(1);
+ throw new RuntimeException("cppcheck detected bad cpp files.");
Review comment:
Just curious. What made you add this in for the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
