nwangtw edited a comment on issue #3248: STREAMCOMP-2724: TMaster migrated to mostly use smart pointers instead of manual memory management URL: https://github.com/apache/incubator-heron/pull/3248#issuecomment-487262779 Seems like build failing. all "make_unique" related. ''' In file included from heron/common/src/cpp/network/network.h:41:0, from heron/common/tests/cpp/network/http_server_unittest.h:24, from heron/common/tests/cpp/network/http_server_unittest.cpp:20: heron/common/src/cpp/network/client.h: In member function 'void Client::InstallResponseHandler(std::unique_ptr<S>, void (T::*)(void*, M*, NetworkErrorCode))': heron/common/src/cpp/network/client.h:134:14: error: 'make_unique' is not a member of 'std' auto m = std::make_unique<M>(); ^ heron/common/src/cpp/network/client.h:134:32: error: expected primary-expression before '>' token auto m = std::make_unique<M>(); ^ heron/common/src/cpp/network/client.h:134:34: error: expected primary-expression before ')' token auto m = std::make_unique<M>(); ^ heron/common/tests/cpp/network/http_server_unittest.cpp: In member function 'void TestHttpServer::HandleMetaRequest(IncomingHTTPRequest*)': heron/common/tests/cpp/network/http_server_unittest.cpp:68:19: error: 'make_unique' is not a member of 'std' auto response = std::make_unique<OutgoingHTTPResponse>(_request); ^ heron/common/tests/cpp/network/http_server_unittest.cpp:68:56: error: expected primary-expression before '>' token auto response = std::make_unique<OutgoingHTTPResponse>(_request); ^ (01:21:01) INFO: Elapsed time: 713.276s, Critical Path: 263.10s (01:21:01) INFO: 534 processes: 492 local, 42 worker. (01:21:01) FAILED: Build did NOT complete successfully (01:21:01) FAILED: Build did NOT complete successfully '''
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
