nwangtw commented on a change in pull request #3248: STREAMCOMP-2724: TMaster
migrated to mostly use smart pointers instead of manual memory management
URL: https://github.com/apache/incubator-heron/pull/3248#discussion_r279890977
##########
File path: heron/tmaster/tests/cpp/server/tmaster_unittest.cpp
##########
@@ -780,7 +780,7 @@ TEST(StMgr, test_runtime_config) {
EXPECT_EQ(updated_bolt_config[bolt_init_config + ":runtime"], "4");
}
std::map<std::string, std::string> updated_config, updated_spout_config,
updated_bolt_config;
- const heron::proto::system::PhysicalPlan* pplan =
common.tmaster_->getPhysicalPlan();
+ auto pplan = common.tmaster_->getPhysicalPlan();
Review comment:
const is removed? I am wondering if they can make the binary more optimized
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
