nlu90 commented on a change in pull request #3283: Set to Kryo serializer when
registerKryoSerialization is called
URL: https://github.com/apache/incubator-heron/pull/3283#discussion_r291303568
##########
File path: heron/api/src/java/org/apache/heron/api/Config.java
##########
@@ -480,11 +480,19 @@ private static List
getRegisteredKryoSerializations(Map<String, Object> conf) {
}
public static void registerKryoSerialization(Map<String, Object> conf, Class
klass) {
+ // Set to Kryo Seralizer when this function is caled. In Storm API, Kryo
seralizer is
+ // the default but it is not in Heron. This implicit set could make
migration easier
+ // since it is more consistent.
+
setSerializationClassName("org.apache.heron.api.serializer.KryoSerializer");
Review comment:
create a final field for this
`"org.apache.heron.api.serializer.KryoSerializer"` string and reuse it
everywhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
