dnrusakov commented on a change in pull request #3282: STREAMCOMP-2724: Stream Manager migrated to mainly use smart pointers instead of a manual memory management URL: https://github.com/apache/incubator-heron/pull/3282#discussion_r292191674
########## File path: heron/stmgr/src/cpp/manager/instance-server.cpp ########## @@ -87,13 +87,14 @@ const sp_string CONNECTION_BUFFER_LENGTH_BY_INSTANCEID = const sp_int64 SYSTEM_METRICS_SAMPLE_INTERVAL_MICROSECOND = 10_s; -InstanceServer::InstanceServer(EventLoop* eventLoop, const NetworkOptions& _options, - const sp_string& _topology_name, const sp_string& _topology_id, - const sp_string& _stmgr_id, - const std::vector<sp_string>& _expected_instances, StMgr* _stmgr, - heron::common::MetricsMgrSt* _metrics_manager_client, - NeighbourCalculator* _neighbour_calculator, - bool _droptuples_upon_backpressure) +InstanceServer::InstanceServer(shared_ptr<EventLoop> eventLoop, const NetworkOptions& _options, + const sp_string& _topology_name, const sp_string& _topology_id, Review comment: fixed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
