rohanag12 commented on issue #3287: Some components do not properly override 
config
URL: 
https://github.com/apache/incubator-heron/issues/3287#issuecomment-502816043
 
 
   @nlu90 The `loadConfig` function you linked looks ideal. However, it is not 
used in all Java code.
   
   Take a look at 
https://github.com/apache/incubator-heron/compare/master...uhanaio:executor-overload-config
 for an example. In metrics manager, the list of metrics sinks to load is read 
separately, in the 
[MetricsSinksConfig](https://github.com/uhanaio/incubator-heron/blob/master/heron/metricsmgr/src/java/org/apache/heron/metricsmgr/MetricsSinksConfig.java)
 class.
   
   Also part of that diff is a change to heron executor, where it does not 
override the statemgr config from `overrides.yaml`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to