joshfischer1108 commented on a change in pull request #3289: Bug/heron-helm
URL: https://github.com/apache/incubator-heron/pull/3289#discussion_r303218476
##########
File path: deploy/kubernetes/helm/templates/tools.yaml
##########
@@ -145,8 +145,8 @@ spec:
-D heron.uploader.s3.region={{ .Values.uploader.s3Region }}
{{- end }}
{{- if eq .Values.packing "RoundRobin" }}
- -D
heron.class.packing.algorithm=org.apache.heron.packing.roundrobin.RoundRobinPacking
Review comment:
Ahh. This needs to be changed back to `org.apache`, but I'm guessing this
was done since they were using `0.17.8` which is still `com.twitter`. We have
a little work to support the newer containers. Good catch @nicknezis. I'm on
the fence about this since we don't have an official Apache Docker container
yet. Leaving it as `com.twitter` will allow people to test with a learn/test
heron easily. This is probably the culprit for the weirdness I was
experiencing the other day with the `rc3` candidate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
