nicknezis commented on a change in pull request #3289: Bug/heron-helm
URL: https://github.com/apache/incubator-heron/pull/3289#discussion_r303631270
##########
File path: deploy/kubernetes/helm/templates/tools.yaml
##########
@@ -145,8 +145,8 @@ spec:
-D heron.uploader.s3.region={{ .Values.uploader.s3Region }}
{{- end }}
{{- if eq .Values.packing "RoundRobin" }}
- -D
heron.class.packing.algorithm=org.apache.heron.packing.roundrobin.RoundRobinPacking
Review comment:
Could we make a 0.17.8 versioned Helm release. Most Helm packages in the
standard charts repo get published to this Google bucket store
(https://console.cloud.google.com/storage/browser/kubernetes-charts-incubator).
A repo like this would have versioned Helm artifacts. Then we could correct
this code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
