joshfischer1108 commented on issue #3313: adding wait for zookeeper script URL: https://github.com/apache/incubator-heron/pull/3313#issuecomment-512933592 I imagine quorum would be what we wanted, I'm not sure to be honest. The reason I added this script in is because the helm chart as it is in the repo today expects this script to be executed. Upon startup of the heron tools the init containers are waiting for zookeeper. See [here](https://github.com/apache/incubator-heron/blob/master/deploy/kubernetes/helm/templates/tools.yaml#L70). I'm trying to pick up where the chart was left off at.. If you use the docker scripts in this [folder](https://github.com/apache/incubator-heron/tree/master/docker) to build a heron docker image with the base as debian9 the helm deployment will fail since this `wait-for-zookeeper.sh` script is not present in the container. With this change I was able to get the helm chart to deploy successfully. Not knowing the full story of the whats or why something was done, I wanted some review on this from someone(s) who may be more familiar with it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
