jemantheiy commented on a change in pull request #3360: udpated yaml and 
updated tools
URL: https://github.com/apache/incubator-heron/pull/3360#discussion_r332627854
 
 

 ##########
 File path: deploy/kubernetes/helm/values.yaml.template
 ##########
 @@ -39,8 +39,9 @@ jobReplicas: 1
 
 # amount of memory to provide for API server
 apiServerMemory: 512M
-
-# Topologies uploader
+heron:
+  url:/api/v1/namespaces/{{ .Release.Namespace }}/services/{{ .Release.Name 
}}-ui:8889/proxy
+i Topologies uploader
 
 Review comment:
   I moved the old proxy url out in the tools yaml and moved it to values.yaml 
so we can override it since our production env won't allow kubectl proxy

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to