joshfischer1108 commented on a change in pull request #3366: Add a script to start docker container with development environment URL: https://github.com/apache/incubator-heron/pull/3366#discussion_r336473156
########## File path: docker/scripts/docker-dev-env.sh ########## @@ -0,0 +1,75 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# This is a script to start a docker container that has all +# tools needed to compire Heron. Developer should be able to +# compile Heron in the container without any setup works. +# usage: +# To create a clean development environment, enter the source +# code directory of Heron and then execute the following scripts: +# sh docker/scripts/docker-dev-env.sh +# To enter an existing container, find the container id with: +# docker ps -a +# Then enter the container by +# docker start -ai CONTAINER_ID +# After the container is started, enter the source code directory +# and build with bazel (assuming it's a ubuntu container): +# cd heron +# bazel build --config=ubuntu heron/... + +set -o nounset +set -o errexit + +# Default platform is ubuntu18.04. Other available platforms +# include centos7 +TARGET_PLATFORM=${1:-"ubuntu18.04"} +SCRATCH_DIR="docker" Review comment: Do you think we should make `SCRATCH_DIR` configurable by accepting an argument as the script is executed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
