nicknezis commented on a change in pull request #3413: Updating to fix 
deprecated Kubernetes APIs
URL: https://github.com/apache/incubator-heron/pull/3413#discussion_r356839314
 
 

 ##########
 File path: deploy/kubernetes/general/tools.yaml
 ##########
 @@ -57,6 +60,13 @@ spec:
               --name=localzk
               --hostport=zookeeper:2181
               --rootpath="/heron"
+          resources:
+            requests:
+              cpu: "100m"
+              memory: "200M"
+            limits:
 
 Review comment:
   I think I found it somewhere else and wanted to make it consistent across 
the files. But I do agree the limits might not be a good idea for some of the 
use cases such as `general` and `minikube` use cases. I'll make the updates to 
clean up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to