nicknezis opened a new pull request #3432: Updated to use default Kubernetes client discovery logic URL: https://github.com/apache/incubator-heron/pull/3432 The defaultClient() call incorporates the following logic: If `$KUBECONFIG` is defined, use that config file. If `$HOME/.kube/config` can be found, use that. If the in-cluster service account can be found, assume in cluster config. Default to `localhost:8080` as a last resort. With this code change, we'd no longer be using the scheduler config item for K8s scheduler URI. But the config item is used to create Job Links. So I couldn't get rid of that config item. Any thoughts on how I could fully remove the scheduler URI config item? Do you think the defaultClient() code is good enough? It seemed to work in my Minikube testing and I figured worst case that last option would point to kubectl-proxy if we update it to use port 8080. I assume if someone needs to run the Heron API Server outside of the k8s cluster, then can configure with the `$KUBECONFIG` environment variable.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
