thinker0 commented on issue #3107: Improve concurrency for needed parts. URL: https://github.com/apache/incubator-heron/pull/3107#issuecomment-589889745 > I see. Make sense then when you use multi threading. In this case you might be better to synchronized {} to make sure ack() is not called many times at the same time. OutputCollector has a queue in it and I am not sure the queue is thread-safe. In Heron engine, the core assumes single thread environment. > > Internally, we build library and use it directly, instead of the ones in Maven. > > bazel build --compilation_mode=dbg --config=darwin scripts/packages:tarpkgs Made the OutputCollector thread-safe. @nwangtw, ``` synchronized ``` works fine without it. And it works well in Production.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
