Code0x58 commented on pull request #3479:
URL: https://github.com/apache/incubator-heron/pull/3479#issuecomment-624362243
_Lead:_ it looks modules are mostly included in PEXs, but they are missing
important `__init__.py` files so aren't being treated as modules.
Example:
```sh
# example generated PEX
pex=./bazel-bin/heron/tools/tracker/tests/python/topology_unittest_runner
for branch in master python-3-upgrade; do
git checkout $branch
bazel clean
./scripts/travis/ci.sh
unzip -d /tmp/out "$pex"
(cd /tmp/out && find *) > $branch.txt
rm -fr /mt
done
diff -U0 master.txt python-3-upgrade
```
```diff
--- master.txt 2020-05-06 00:21:03.540305580 +0100
+++ branch.txt 2020-05-06 00:28:39.988906082 +0100
@@ -2 +1,0 @@
-heron/__init__.py
@@ -12 +10,0 @@
-heron/proto/__init__.py
@@ -31 +28,0 @@
-heron/tools/tracker/__init__.py
@@ -37 +33,0 @@
-heron/tools/tracker/tests/python/__init__.py
@@ -39 +34,0 @@
-heron/tools/tracker/tests/__init__.py
@@ -109 +103,0 @@
-heron/tools/tracker/src/python/__init__.py
@@ -120,2 +113,0 @@
-heron/tools/tracker/src/__init__.py
-heron/tools/__init__.py
@@ -123 +114,0 @@
-heron/tools/common/__init__.py
@@ -126 +116,0 @@
-heron/tools/common/src/python/__init__.py
@@ -131 +120,0 @@
-heron/tools/common/src/python/utils/__init__.py
@@ -146 +134,0 @@
-heron/tools/common/src/__init__.py
@@ -148 +135,0 @@
-heron/common/__init__.py
@@ -162 +148,0 @@
-heron/common/src/__init__.py
@@ -164 +149,0 @@
-heron/statemgrs/__init__.py
@@ -176 +160,0 @@
-heron/statemgrs/src/python/__init__.py
@@ -184 +167,0 @@
-heron/statemgrs/src/__init__.py
@@ -186 +168,0 @@
-heronpy/__init__.py
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
