Code0x58 opened a new issue #3557:
URL: https://github.com/apache/incubator-heron/issues/3557


   While upgrading to python3, the bazel protobuf rules took [some 
coercing](https://github.com/apache/incubator-heron/blob/4f7f90f2b823dc7e714ee2898b033cfc78f88cb0/tools/rules/genproto.bzl#L168)
 to get around https://github.com/protocolbuffers/protobuf/issues/1491. A 
better solution should be used to clean up code and improve stability†. It 
seems to me that these are options, by order of preference:
    - using standard protobuf bazel rules and their `import_prefix`
    - pursue https://github.com/protocolbuffers/protobuf/pull/7470
    - use relative paths in the protoc command so the imports are absolute 
(mentioned in issue)
   
   † the build may flake due to files being removed while they are being 
iterated over


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to