nicknezis commented on a change in pull request #3561:
URL: https://github.com/apache/incubator-heron/pull/3561#discussion_r453106869
##########
File path: heron/config/src/yaml/conf/kubernetes/statemgr.yaml
##########
@@ -19,7 +19,7 @@
heron.class.state.manager:
org.apache.heron.statemgr.zookeeper.curator.CuratorStateManager
# local state manager connection string
-heron.statemgr.connection.string: <zookeeper_host:zookeeper_port>
+heron.statemgr.connection.string: 127.0.0.1:2181
Review comment:
Yeah I think it was a place holder for someone configuring Heron to run
in Kubernetes. But each of our K8s yamls actually override the setting as a
`-D` parameter passed in to the `heron-apiserver` command. So I don't think
your code change would impact anything beyond it not being immediately apparent
that this is no longer a placeholder. I wonder what part of the test scripts
need direct Zookeeper access.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
