joshfischer1108 commented on a change in pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#discussion_r457001709
##########
File path: heron/statemgrs/src/python/zkstatemanager.py
##########
@@ -170,7 +170,7 @@ def _get_topology_with_watch(self, topologyName, callback,
isWatching):
# pylint: disable=unused-variable, unused-argument
@self.client.DataWatch(path)
- def watch_topology(data, stats):
+ def watch_topology(data, stats, event):
""" watch topology """
if data:
topology = Topology()
Review comment:
I think I see the problem (mismatch number of passed arguments) you are
trying to address.
```
"/Users/someUser/.pex/installed_wheels/7b3448a0635a4c114f98f11df06af06d250c297a/kazoo-2.7.0-py2.py3-none-any.whl/kazoo/recipe/watchers.py",
line 162, in _log_func_exception
result = self._func(data, stat, event)
TypeError: watch_execution_state() takes 2 positional arguments but 3 were
given
```
I'm not sure I follow the reasoning of adding `event` to each of the method
signatures. If it is never used, why do we need to pass it at all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
