svn commit: r1198566 - in /hive/trunk/ql/src: java/org/apache/hadoop/hive/ql/exec/ test/queries/clientnegative/ test/queries/clientpositive/ test/results/clientnegative/ test/results/clientpositive/

Sun, 06 Nov 2011 13:22:50 -0800 

Author: jvs
Date: Sun Nov  6 21:22:22 2011
New Revision: 1198566

URL: http://svn.apache.org/viewvc?rev=1198566&view=rev
Log:
HIVE-11. better error code from Hive describe command
(Ashutosh Chauhan via jvs)


Added:
    hive/trunk/ql/src/test/queries/clientpositive/desc_non_existent_tbl.q
    hive/trunk/ql/src/test/results/clientpositive/desc_non_existent_tbl.q.out
Modified:
    hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
    hive/trunk/ql/src/test/queries/clientnegative/external1.q
    hive/trunk/ql/src/test/queries/clientnegative/external2.q
    hive/trunk/ql/src/test/results/clientnegative/external1.q.out
    hive/trunk/ql/src/test/results/clientnegative/external2.q.out

Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
URL: 
http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java?rev=1198566&r1=1198565&r2=1198566&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 
(original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java Sun Nov  
6 21:22:22 2011
@@ -2516,7 +2516,7 @@ public class DDLTask extends Task<DDLWor
       Path resFile = new Path(descTbl.getResFile());
       if (tbl == null) {
         FileSystem fs = resFile.getFileSystem(conf);
-        outStream = (DataOutput) fs.open(resFile);
+        outStream = fs.create(resFile);
         String errMsg = "Table " + tableName + " does not exist";
         outStream.write(errMsg.getBytes("UTF-8"));
         ((FSDataOutputStream) outStream).close();
@@ -2527,7 +2527,7 @@ public class DDLTask extends Task<DDLWor
         part = db.getPartition(tbl, descTbl.getPartSpec(), false);
         if (part == null) {
           FileSystem fs = resFile.getFileSystem(conf);
-          outStream = (DataOutput) fs.open(resFile);
+          outStream = fs.create(resFile);
           String errMsg = "Partition " + descTbl.getPartSpec() + " for table "
               + tableName + " does not exist";
           outStream.write(errMsg.getBytes("UTF-8"));

Modified: hive/trunk/ql/src/test/queries/clientnegative/external1.q
URL: 
http://svn.apache.org/viewvc/hive/trunk/ql/src/test/queries/clientnegative/external1.q?rev=1198566&r1=1198565&r2=1198566&view=diff
==============================================================================
--- hive/trunk/ql/src/test/queries/clientnegative/external1.q (original)
+++ hive/trunk/ql/src/test/queries/clientnegative/external1.q Sun Nov  6 
21:22:22 2011
@@ -1,4 +1,3 @@
-set hive.cli.errors.ignore=true;
 
 create external table external1(a int, b int) location 
'invalidscheme://data.s3ndemo.hive/kv';
 describe external1;

Modified: hive/trunk/ql/src/test/queries/clientnegative/external2.q
URL: 
http://svn.apache.org/viewvc/hive/trunk/ql/src/test/queries/clientnegative/external2.q?rev=1198566&r1=1198565&r2=1198566&view=diff
==============================================================================
--- hive/trunk/ql/src/test/queries/clientnegative/external2.q (original)
+++ hive/trunk/ql/src/test/queries/clientnegative/external2.q Sun Nov  6 
21:22:22 2011
@@ -1,4 +1,3 @@
-set hive.cli.errors.ignore=true;
 
 create external table external2(a int, b int) partitioned by (ds string);
 alter table external2 add partition (ds='2008-01-01') location 
'invalidscheme://data.s3ndemo.hive/pkv/2008-01-01';

Added: hive/trunk/ql/src/test/queries/clientpositive/desc_non_existent_tbl.q
URL: 
http://svn.apache.org/viewvc/hive/trunk/ql/src/test/queries/clientpositive/desc_non_existent_tbl.q?rev=1198566&view=auto
==============================================================================
--- hive/trunk/ql/src/test/queries/clientpositive/desc_non_existent_tbl.q 
(added)
+++ hive/trunk/ql/src/test/queries/clientpositive/desc_non_existent_tbl.q Sun 
Nov  6 21:22:22 2011
@@ -0,0 +1 @@
+desc nonexistenttbl;

Modified: hive/trunk/ql/src/test/results/clientnegative/external1.q.out
URL: 
http://svn.apache.org/viewvc/hive/trunk/ql/src/test/results/clientnegative/external1.q.out?rev=1198566&r1=1198565&r2=1198566&view=diff
==============================================================================
--- hive/trunk/ql/src/test/results/clientnegative/external1.q.out (original)
+++ hive/trunk/ql/src/test/results/clientnegative/external1.q.out Sun Nov  6 
21:22:22 2011
@@ -2,6 +2,3 @@ PREHOOK: query: create external table ex
 PREHOOK: type: CREATETABLE
 FAILED: Error in metadata: MetaException(message:Got exception: 
java.io.IOException No FileSystem for scheme: invalidscheme)
 FAILED: Execution Error, return code 1 from 
org.apache.hadoop.hive.ql.exec.DDLTask
-PREHOOK: query: describe external1
-PREHOOK: type: DESCTABLE
-FAILED: Execution Error, return code 1 from 
org.apache.hadoop.hive.ql.exec.DDLTask

Modified: hive/trunk/ql/src/test/results/clientnegative/external2.q.out
URL: 
http://svn.apache.org/viewvc/hive/trunk/ql/src/test/results/clientnegative/external2.q.out?rev=1198566&r1=1198565&r2=1198566&view=diff
==============================================================================
--- hive/trunk/ql/src/test/results/clientnegative/external2.q.out (original)
+++ hive/trunk/ql/src/test/results/clientnegative/external2.q.out Sun Nov  6 
21:22:22 2011
@@ -8,6 +8,3 @@ PREHOOK: type: ALTERTABLE_ADDPARTS
 PREHOOK: Input: default@external2
 FAILED: Error in metadata: MetaException(message:Got exception: 
java.io.IOException No FileSystem for scheme: invalidscheme)
 FAILED: Execution Error, return code 1 from 
org.apache.hadoop.hive.ql.exec.DDLTask
-PREHOOK: query: describe external2 partition (ds='2008-01-01')
-PREHOOK: type: DESCTABLE
-FAILED: Execution Error, return code 1 from 
org.apache.hadoop.hive.ql.exec.DDLTask

Added: hive/trunk/ql/src/test/results/clientpositive/desc_non_existent_tbl.q.out
URL: 
http://svn.apache.org/viewvc/hive/trunk/ql/src/test/results/clientpositive/desc_non_existent_tbl.q.out?rev=1198566&view=auto
==============================================================================
--- hive/trunk/ql/src/test/results/clientpositive/desc_non_existent_tbl.q.out 
(added)
+++ hive/trunk/ql/src/test/results/clientpositive/desc_non_existent_tbl.q.out 
Sun Nov  6 21:22:22 2011
@@ -0,0 +1,5 @@
+PREHOOK: query: desc nonexistenttbl
+PREHOOK: type: DESCTABLE
+POSTHOOK: query: desc nonexistenttbl
+POSTHOOK: type: DESCTABLE
+Table nonexistenttbl does not exist

Reply via email to