Author: rhbutani
Date: Thu Mar 27 15:29:40 2014
New Revision: 1582354
URL: http://svn.apache.org/r1582354
Log:
HIVE-2752 Index names are case sensitive (Navis Ryu via Harish Butani)
Modified:
hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
hive/trunk/ql/src/test/queries/clientpositive/index_auth.q
hive/trunk/ql/src/test/results/clientpositive/index_auth.q.out
Modified:
hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
URL:
http://svn.apache.org/viewvc/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java?rev=1582354&r1=1582353&r2=1582354&view=diff
==============================================================================
---
hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
(original)
+++
hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Thu Mar 27 15:29:40 2014
@@ -2844,7 +2844,7 @@ public class ObjectStore implements RawS
"Underlying index table does not exist for the given index.");
}
- return new MIndex(index.getIndexName(), origTable, index.getCreateTime(),
+ return new MIndex(index.getIndexName().toLowerCase(), origTable,
index.getCreateTime(),
index.getLastAccessTime(), index.getParameters(), indexTable, msd,
index.getIndexHandlerClass(), index.isDeferredRebuild());
}
@@ -2885,7 +2885,7 @@ public class ObjectStore implements RawS
"origTable.tableName == t1 && origTable.database.name == t2 &&
indexName == t3");
query.declareParameters("java.lang.String t1, java.lang.String t2,
java.lang.String t3");
query.setUnique(true);
- midx = (MIndex) query.execute(originalTblName, dbName, indexName);
+ midx = (MIndex) query.execute(originalTblName, dbName,
indexName.toLowerCase());
pm.retrieve(midx);
commited = commitTransaction();
} finally {
Modified: hive/trunk/ql/src/test/queries/clientpositive/index_auth.q
URL:
http://svn.apache.org/viewvc/hive/trunk/ql/src/test/queries/clientpositive/index_auth.q?rev=1582354&r1=1582353&r2=1582354&view=diff
==============================================================================
--- hive/trunk/ql/src/test/queries/clientpositive/index_auth.q (original)
+++ hive/trunk/ql/src/test/queries/clientpositive/index_auth.q Thu Mar 27
15:29:40 2014
@@ -2,14 +2,16 @@ SET hive.input.format=org.apache.hadoop.
create table foobar(key int, value string) PARTITIONED BY (ds string, hr
string);
alter table foobar add partition (ds='2008-04-08',hr='12');
-CREATE INDEX srcpart_auth_index ON TABLE foobar(key) as 'BITMAP' WITH DEFERRED
REBUILD;
+CREATE INDEX srcpart_AUTH_index ON TABLE foobar(key) as 'BITMAP' WITH DEFERRED
REBUILD;
+SHOW INDEXES ON foobar;
+
grant select on table foobar to user hive_test_user;
-grant select on table default__foobar_srcpart_auth_index__ to user
hive_test_user;
-grant update on table default__foobar_srcpart_auth_index__ to user
hive_test_user;
-grant create on table default__foobar_srcpart_auth_index__ to user
hive_test_user;
+grant select on table default__foobar_srcpart_auth_indeX__ to user
hive_test_user;
+grant update on table default__foobar_srcpart_auth_indEx__ to user
hive_test_user;
+grant create on table default__foobar_srcpart_auth_inDex__ to user
hive_test_user;
set hive.security.authorization.enabled=true;
-ALTER INDEX srcpart_auth_index ON foobar PARTITION (ds='2008-04-08',hr='12')
REBUILD;
+ALTER INDEX srcpart_auth_INDEX ON foobar PARTITION (ds='2008-04-08',hr='12')
REBUILD;
set hive.security.authorization.enabled=false;
DROP INDEX srcpart_auth_index on foobar;
DROP TABLE foobar;
Modified: hive/trunk/ql/src/test/results/clientpositive/index_auth.q.out
URL:
http://svn.apache.org/viewvc/hive/trunk/ql/src/test/results/clientpositive/index_auth.q.out?rev=1582354&r1=1582353&r2=1582354&view=diff
==============================================================================
--- hive/trunk/ql/src/test/results/clientpositive/index_auth.q.out (original)
+++ hive/trunk/ql/src/test/results/clientpositive/index_auth.q.out Thu Mar 27
15:29:40 2014
@@ -12,41 +12,46 @@ POSTHOOK: query: alter table foobar add
POSTHOOK: type: ALTERTABLE_ADDPARTS
POSTHOOK: Output: default@foobar
POSTHOOK: Output: default@foobar@ds=2008-04-08/hr=12
-PREHOOK: query: CREATE INDEX srcpart_auth_index ON TABLE foobar(key) as
'BITMAP' WITH DEFERRED REBUILD
+PREHOOK: query: CREATE INDEX srcpart_AUTH_index ON TABLE foobar(key) as
'BITMAP' WITH DEFERRED REBUILD
PREHOOK: type: CREATEINDEX
-POSTHOOK: query: CREATE INDEX srcpart_auth_index ON TABLE foobar(key) as
'BITMAP' WITH DEFERRED REBUILD
+POSTHOOK: query: CREATE INDEX srcpart_AUTH_index ON TABLE foobar(key) as
'BITMAP' WITH DEFERRED REBUILD
POSTHOOK: type: CREATEINDEX
POSTHOOK: Output: default@default__foobar_srcpart_auth_index__
+PREHOOK: query: SHOW INDEXES ON foobar
+PREHOOK: type: SHOWINDEXES
+POSTHOOK: query: SHOW INDEXES ON foobar
+POSTHOOK: type: SHOWINDEXES
+srcpart_auth_index foobar key
default__foobar_srcpart_auth_index__ bitmap
PREHOOK: query: grant select on table foobar to user hive_test_user
PREHOOK: type: GRANT_PRIVILEGE
PREHOOK: Output: default@foobar
POSTHOOK: query: grant select on table foobar to user hive_test_user
POSTHOOK: type: GRANT_PRIVILEGE
POSTHOOK: Output: default@foobar
-PREHOOK: query: grant select on table default__foobar_srcpart_auth_index__ to
user hive_test_user
+PREHOOK: query: grant select on table default__foobar_srcpart_auth_indeX__ to
user hive_test_user
PREHOOK: type: GRANT_PRIVILEGE
PREHOOK: Output: default@default__foobar_srcpart_auth_index__
-POSTHOOK: query: grant select on table default__foobar_srcpart_auth_index__ to
user hive_test_user
+POSTHOOK: query: grant select on table default__foobar_srcpart_auth_indeX__ to
user hive_test_user
POSTHOOK: type: GRANT_PRIVILEGE
POSTHOOK: Output: default@default__foobar_srcpart_auth_index__
-PREHOOK: query: grant update on table default__foobar_srcpart_auth_index__ to
user hive_test_user
+PREHOOK: query: grant update on table default__foobar_srcpart_auth_indEx__ to
user hive_test_user
PREHOOK: type: GRANT_PRIVILEGE
PREHOOK: Output: default@default__foobar_srcpart_auth_index__
-POSTHOOK: query: grant update on table default__foobar_srcpart_auth_index__ to
user hive_test_user
+POSTHOOK: query: grant update on table default__foobar_srcpart_auth_indEx__ to
user hive_test_user
POSTHOOK: type: GRANT_PRIVILEGE
POSTHOOK: Output: default@default__foobar_srcpart_auth_index__
-PREHOOK: query: grant create on table default__foobar_srcpart_auth_index__ to
user hive_test_user
+PREHOOK: query: grant create on table default__foobar_srcpart_auth_inDex__ to
user hive_test_user
PREHOOK: type: GRANT_PRIVILEGE
PREHOOK: Output: default@default__foobar_srcpart_auth_index__
-POSTHOOK: query: grant create on table default__foobar_srcpart_auth_index__ to
user hive_test_user
+POSTHOOK: query: grant create on table default__foobar_srcpart_auth_inDex__ to
user hive_test_user
POSTHOOK: type: GRANT_PRIVILEGE
POSTHOOK: Output: default@default__foobar_srcpart_auth_index__
-PREHOOK: query: ALTER INDEX srcpart_auth_index ON foobar PARTITION
(ds='2008-04-08',hr='12') REBUILD
+PREHOOK: query: ALTER INDEX srcpart_auth_INDEX ON foobar PARTITION
(ds='2008-04-08',hr='12') REBUILD
PREHOOK: type: ALTERINDEX_REBUILD
PREHOOK: Input: default@foobar
PREHOOK: Input: default@foobar@ds=2008-04-08/hr=12
PREHOOK: Output:
default@default__foobar_srcpart_auth_index__@ds=2008-04-08/hr=12
-POSTHOOK: query: ALTER INDEX srcpart_auth_index ON foobar PARTITION
(ds='2008-04-08',hr='12') REBUILD
+POSTHOOK: query: ALTER INDEX srcpart_auth_INDEX ON foobar PARTITION
(ds='2008-04-08',hr='12') REBUILD
POSTHOOK: type: ALTERINDEX_REBUILD
POSTHOOK: Input: default@foobar
POSTHOOK: Input: default@foobar@ds=2008-04-08/hr=12
