Author: jdere
Date: Thu Sep 18 22:40:39 2014
New Revision: 1626095
URL: http://svn.apache.org/r1626095
Log:
HIVE-8081: "drop index if exists" fails if table specified does not exist
(Jason Dere, reviewed by Thejas Nair)
Modified:
hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
hive/trunk/ql/src/test/queries/clientpositive/drop_index.q
hive/trunk/ql/src/test/results/clientpositive/drop_index.q.out
Modified:
hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
URL:
http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java?rev=1626095&r1=1626094&r2=1626095&view=diff
==============================================================================
---
hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
(original)
+++
hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
Thu Sep 18 22:40:39 2014
@@ -1145,7 +1145,10 @@ public class DDLSemanticAnalyzer extends
}
}
- inputs.add(new ReadEntity(getTable(tableName)));
+ Table tbl = getTable(tableName, false);
+ if (tbl != null) {
+ inputs.add(new ReadEntity(getTable(tableName)));
+ }
DropIndexDesc dropIdxDesc = new DropIndexDesc(indexName, tableName);
rootTasks.add(TaskFactory.get(new DDLWork(getInputs(), getOutputs(),
Modified: hive/trunk/ql/src/test/queries/clientpositive/drop_index.q
URL:
http://svn.apache.org/viewvc/hive/trunk/ql/src/test/queries/clientpositive/drop_index.q?rev=1626095&r1=1626094&r2=1626095&view=diff
==============================================================================
--- hive/trunk/ql/src/test/queries/clientpositive/drop_index.q (original)
+++ hive/trunk/ql/src/test/queries/clientpositive/drop_index.q Thu Sep 18
22:40:39 2014
@@ -1,2 +1,3 @@
SET hive.exec.drop.ignorenonexistent=false;
DROP INDEX IF EXISTS UnknownIndex ON src;
+DROP INDEX IF EXISTS UnknownIndex ON UnknownTable;
Modified: hive/trunk/ql/src/test/results/clientpositive/drop_index.q.out
URL:
http://svn.apache.org/viewvc/hive/trunk/ql/src/test/results/clientpositive/drop_index.q.out?rev=1626095&r1=1626094&r2=1626095&view=diff
==============================================================================
--- hive/trunk/ql/src/test/results/clientpositive/drop_index.q.out (original)
+++ hive/trunk/ql/src/test/results/clientpositive/drop_index.q.out Thu Sep 18
22:40:39 2014
@@ -4,3 +4,7 @@ PREHOOK: Input: default@src
POSTHOOK: query: DROP INDEX IF EXISTS UnknownIndex ON src
POSTHOOK: type: DROPINDEX
POSTHOOK: Input: default@src
+PREHOOK: query: DROP INDEX IF EXISTS UnknownIndex ON UnknownTable
+PREHOOK: type: DROPINDEX
+POSTHOOK: query: DROP INDEX IF EXISTS UnknownIndex ON UnknownTable
+POSTHOOK: type: DROPINDEX
